fix(nodebuilder/core): non default values from config.toml are written over by flag defaults in specific circumstances #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues from config.toml would be overwritten by defaults if any core.ip was provided as a cli flag
…nfig with no defaults (likely never happen)
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
Wondertan
reviewed
Jun 25, 2024
…refer fail on validation, also fill out tests for Validate
Wondertan
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identified by @tac0turtle (TYBG) whereby, in the specific case where you had edited you node store's config values to be non-default for
Core.RPCPortorCore.GRPCPort, if you were to then provide a different value for Core.IP via the--core.ipflag at node start time, then the flag defaults forcore.rpc.portandcore.grpc.portwould revert the values to defaults and override the custom values in config.toml. Fix is to check that the default value had been reset in the flag, and only use the default if no value had been set in the passed in config, which in most cases is already loaded as default or the config.toml values.Took liberty to add some tests, and update some duplication of default values while in here.
fixes #3523